I just finished checking everything down to the smallest detail on all topics, so I think I'm done.

Some screenshots compared to v0.21.0

@krlvm thank you for this huge improvement! It does have many benefits. :-D
Could you better explain how this new theming strategy works? Since there are ~300 changed files I don't understand which ones contain the important changes.
Also, did you test on API 19?

@TobiGr I'd give priority to this PR, is would be painful to rebase 300 files ;-)

@krlvm thank you for this huge improvement! It does have many benefits. :-D
Could you better explain how this new theming strategy works? Since there are ~300 changed files I don't understand which ones contain the important changes.
Also, did you test on API 19?

@TobiGr I'd give priority to this PR, is would be painful to rebase 300 files ;-)

In fact, this number is not scary, I just renamed all files like ic_x_white_24dp to ic_x, as well as all references to it. Likewise with dark versions moved to drawable-night. That's where the 300 changes come from, though

The theming strategy has not been changed much for that. To make the resource source automatically change from drawable to drawable-night, we use AppCompatDelegate.setDefaultNightMode(), which is available by using DayNight as the base theme.
To force invert the colors of the drawables (for example, the control buttons in the player are always white), we give the layout the WhiteTint theme.

Important changes are in:

• ThemeHelper
• styles.xml files
• android:theme attribute for Toolbars and Player's container (WhiteTintTheme)
• TabLayout icons colors changed via XML attributes too

Also got rid of icons in attrs.xml and ThemeHelper.resolveResourceIdFromAttr as I said before.

Also, did you test on API 19?

Screenshots

There also some problems with tab on-tap-highlight color (it is 100% opaque) on KitKat.

The icons of the items in "Settings -> Content -> Content of main page -> + -> Kiosk page" are white under white theme, even though they should be black. This is not caused by your PR, but if it's not an issue please fix it while you are at it ;-)

Should be fixed now

• This happens on API 19 and API 30, but not on my phone with API 29:

• This happens only on API 19:

• Some icons in the notification on API 19 are invisible (I noticed the buffering icon and the close icon in particular, but maybe even others, idk if this was caused by this PR)

Can't reproduce the last issue, two others were fixed

I'm actually really excited for this PR (DayNight usage is something I've wanted for quite a while, plus no more themed drawables). Hoping as many bugs as possible will be ironed out before merge-time :)

actually it appears this is already ironed out alot? Why not merge it and let it test with the RC for the next release?

I cannot find any more problems on the last two versions of Android, which I use, at least in the most used activities, but additional flaws on API 19 may be revealed. Anyway, thanks for taking the time to find those problems that I could not discover before opening the PR.

Did anyone test this on a TV?

@TobiGr I didn't think of that, I'm going to test now on an emulator

I tested again, even on an emulated TV (API 29), and couldn't find anything wrong, both in white and dark/black theme. I think this can be merged, since potential problems would anyway only be color problems, not usability issues.

Release build failed:
app/src/release/res/xml/main_settings.xml:43: AAPT: error: resource drawable/ic_cloud_download_black (aka org.schabi.newpipe:drawable/ic_cloud_download_black) not found.

Release build failed:
app/src/release/res/xml/main_settings.xml:43: AAPT: error: resource drawable/ic_cloud_download_black (aka org.schabi.newpipe:drawable/ic_cloud_download_black) not found.

Try replacing ic_cloud_download_black with ic_cloud_download